Dropping proton-dump; Moving to newer minimum CMake version

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Dropping proton-dump; Moving to newer minimum CMake version

Andrew Stitcher
I've been doing some build tree maintenance in Proton and a couple of
issues have come up:

1. Is anyone using/have a reason to want to keep proton-dump? It's a
somewhat odd program that seems to have been a debugging tool left over
from the very earliest days of proton.

It uses the internals of the proton-c library so it can't be simply
linked in with the qpid-proton library without exposing internal
symbols.

For the present I've just linked it directly with the few c files that
provide the symbols it needs.

2. I'd like to move the minimum required CMake version to 2.8.7 - This
will allow me to tidy up a certain amount of the build system and also
provide a somewhat more featureful base version of CMake (currently we
support 2.6 onwards)

As far as I can tell:

Ubuntu12.04LTS: CMake 2.8.7 (version on regular TravisCI build)
RHEL6: CMake 2.8.12
Debian Wheezy (7): CMake 2.8.9
Fedora 22: CMake 3.4.1

Version of CMake on appveyor currently seems to be at least 3.3.2

So I don't think there should be a probelm for anyone with this change.

I'll wait for 3 days and if I don't hear anything from anyone, I'll
assume that no one wants to keep proton-dump and no one objects to
upping the minimum supported version of CMake.

Thanks

Andrew

Reply | Threaded
Open this post in threaded view
|

Re: Dropping proton-dump; Moving to newer minimum CMake version

Chuck Rolke
+1, +1.

I'm ok with both these changes.

Proton dump was handy on some occasions when new clients were sending bogus frames that got confused by Wireshark. Normally Wireshark is fine but proton-dump is a good authority. It was probably more useful in proton's infancy and is unused today.

I use a minimum CMake of 2.8.11 on my windows systems.

--Chuck

----- Original Message -----

> From: "Andrew Stitcher" <[hidden email]>
> To: "proton" <[hidden email]>, "Qpid Developers" <[hidden email]>
> Sent: Monday, February 15, 2016 5:03:40 PM
> Subject: Dropping proton-dump; Moving to newer minimum CMake version
>
> I've been doing some build tree maintenance in Proton and a couple of
> issues have come up:
>
> 1. Is anyone using/have a reason to want to keep proton-dump? It's a
> somewhat odd program that seems to have been a debugging tool left over
> from the very earliest days of proton.
>
> It uses the internals of the proton-c library so it can't be simply
> linked in with the qpid-proton library without exposing internal
> symbols.
>
> For the present I've just linked it directly with the few c files that
> provide the symbols it needs.
>
> 2. I'd like to move the minimum required CMake version to 2.8.7 - This
> will allow me to tidy up a certain amount of the build system and also
> provide a somewhat more featureful base version of CMake (currently we
> support 2.6 onwards)
>
> As far as I can tell:
>
> Ubuntu12.04LTS: CMake 2.8.7 (version on regular TravisCI build)
> RHEL6: CMake 2.8.12
> Debian Wheezy (7): CMake 2.8.9
> Fedora 22: CMake 3.4.1
>
> Version of CMake on appveyor currently seems to be at least 3.3.2
>
> So I don't think there should be a probelm for anyone with this change.
>
> I'll wait for 3 days and if I don't hear anything from anyone, I'll
> assume that no one wants to keep proton-dump and no one objects to
> upping the minimum supported version of CMake.
>
> Thanks
>
> Andrew
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Dropping proton-dump; Moving to newer minimum CMake version

Ken Giusti
In reply to this post by Andrew Stitcher


----- Original Message -----
> From: "Andrew Stitcher" <[hidden email]>
> To: "proton" <[hidden email]>, "Qpid Developers" <[hidden email]>
> Sent: Monday, February 15, 2016 5:03:40 PM
> Subject: Dropping proton-dump; Moving to newer minimum CMake version
>
> I've been doing some build tree maintenance in Proton and a couple of
> issues have come up:
>
> 1. Is anyone using/have a reason to want to keep proton-dump?

Nope - get rid of it.

> It's a
> somewhat odd program that seems to have been a debugging tool left over
> from the very earliest days of proton.
>
> It uses the internals of the proton-c library so it can't be simply
> linked in with the qpid-proton library without exposing internal
> symbols.
>
> For the present I've just linked it directly with the few c files that
> provide the symbols it needs.
>
> 2. I'd like to move the minimum required CMake version to 2.8.7 - This
> will allow me to tidy up a certain amount of the build system and also
> provide a somewhat more featureful base version of CMake (currently we
> support 2.6 onwards)
>
> As far as I can tell:
>
> Ubuntu12.04LTS: CMake 2.8.7 (version on regular TravisCI build)
> RHEL6: CMake 2.8.12
> Debian Wheezy (7): CMake 2.8.9
> Fedora 22: CMake 3.4.1
>

In general +1.  What version does Windows use?

> Version of CMake on appveyor currently seems to be at least 3.3.2
>
> So I don't think there should be a probelm for anyone with this change.
>
> I'll wait for 3 days and if I don't hear anything from anyone, I'll
> assume that no one wants to keep proton-dump and no one objects to
> upping the minimum supported version of CMake.
>
> Thanks
>
> Andrew
>
>

--
-K
Reply | Threaded
Open this post in threaded view
|

Re: Dropping proton-dump; Moving to newer minimum CMake version

Andrew Stitcher
In reply to this post by Chuck Rolke
On Mon, 2016-02-15 at 17:16 -0500, Chuck Rolke wrote:
> ..
>
> I use a minimum CMake of 2.8.11 on my windows systems.

Thanks for the info - FWIW I'd upgrade to atleast 2.8.12 If I were you
(it's the last 2.8 version before they jumped to 3.x)

Andrew

Reply | Threaded
Open this post in threaded view
|

Re: Dropping proton-dump; Moving to newer minimum CMake version

Andrew Stitcher
In reply to this post by Ken Giusti
On Mon, 2016-02-15 at 17:36 -0500, Ken Giusti wrote:
> ...
> In general +1.  What version does Windows use?

In general Windows builds will use whatever you install on them (as
CMake isn't packaged with Windows in anyway).

Specifically the version packaged by chocolatey (http://chocolatey.org)
is currently 3.4.3 - So if you use those packages and keep up to date
you'll have that.

Andrew

Reply | Threaded
Open this post in threaded view
|

Re: Dropping proton-dump; Moving to newer minimum CMake version

aconway.rh
In reply to this post by Ken Giusti
+1 from me
On Mon, 2016-02-15 at 17:36 -0500, Ken Giusti wrote:

>
> ----- Original Message -----
> > From: "Andrew Stitcher" <[hidden email]>
> > To: "proton" <[hidden email]>, "Qpid Developers" <dev@qpid.
> > apache.org>
> > Sent: Monday, February 15, 2016 5:03:40 PM
> > Subject: Dropping proton-dump; Moving to newer minimum CMake
> > version
> >
> > I've been doing some build tree maintenance in Proton and a couple
> > of
> > issues have come up:
> >
> > 1. Is anyone using/have a reason to want to keep proton-dump?
>
> Nope - get rid of it.
>
> > It's a
> > somewhat odd program that seems to have been a debugging tool left
> > over
> > from the very earliest days of proton.
> >
> > It uses the internals of the proton-c library so it can't be simply
> > linked in with the qpid-proton library without exposing internal
> > symbols.
> >
> > For the present I've just linked it directly with the few c files
> > that
> > provide the symbols it needs.
> >
> > 2. I'd like to move the minimum required CMake version to 2.8.7 -
> > This
> > will allow me to tidy up a certain amount of the build system and
> > also
> > provide a somewhat more featureful base version of CMake (currently
> > we
> > support 2.6 onwards)
> >
> > As far as I can tell:
> >
> > Ubuntu12.04LTS: CMake 2.8.7 (version on regular TravisCI build)
> > RHEL6: CMake 2.8.12
> > Debian Wheezy (7): CMake 2.8.9
> > Fedora 22: CMake 3.4.1
> >
>
> In general +1.  What version does Windows use?
>
> > Version of CMake on appveyor currently seems to be at least 3.3.2
> >
> > So I don't think there should be a probelm for anyone with this
> > change.
> >
> > I'll wait for 3 days and if I don't hear anything from anyone, I'll
> > assume that no one wants to keep proton-dump and no one objects to
> > upping the minimum supported version of CMake.
> >
> > Thanks
> >
> > Andrew
> >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Dropping proton-dump; Moving to newer minimum CMake version

Andrew Stitcher
In reply to this post by Andrew Stitcher
Well I left it 3 days, heard no objections so I will remove proton-dump
and up the minimum version of cmake to 2.8.7.

Andrew

Reply | Threaded
Open this post in threaded view
|

Re: Dropping proton-dump; Moving to newer minimum CMake version

Chuck Rolke
A multi-frame issues showed up at https://issues.apache.org/jira/browse/DISPATCH-263 and I think proton-dump was useful in figuring it out.

Wireshark marked dozens of frames with decode errors. proton-dump[1] came to the rescue was able to grind through the packets without complaining. Problem analysis could immediately move beyond figuring out what's wrong with the data stream because it was fine.

I don't need to add proton-dump back into the source tree but I have it built and ready for the occasional need.

-Chuck

[1] proton-dump was opening the dump files in text mode and causing a confusing truncation error. If you plan to use proton-dump you should apply this:

diff --git a/proton-c/src/proton-dump.c b/proton-c/src/proton-dump.c
index 1ce577d..f0718ac 100644
--- a/proton-c/src/proton-dump.c
+++ b/proton-c/src/proton-dump.c
@@ -39,7 +39,7 @@ void fatal_error(const char *msg, const char *arg, int err)

 int dump(const char *file)
 {
-  FILE *in = fopen(file, "r");
+  FILE *in = fopen(file, "rb");
   if (!in) fatal_error("proton-dump: dump: opening %s", file, errno);

   pn_buffer_t *buf = pn_buffer(1024);

----- Original Message -----

> From: "Andrew Stitcher" <[hidden email]>
> To: [hidden email], "Qpid Developers" <[hidden email]>
> Sent: Friday, February 19, 2016 10:04:40 AM
> Subject: Re: Dropping proton-dump; Moving to newer minimum CMake version
>
> Well I left it 3 days, heard no objections so I will remove proton-dump
> and up the minimum version of cmake to 2.8.7.
>
> Andrew
>
>