[GitHub] [qpid-dispatch] jiridanek opened a new pull request #983: Jd 2021 01 16 update npm

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [qpid-dispatch] jiridanek opened a new pull request #983: Jd 2021 01 16 update npm

GitBox

jiridanek opened a new pull request #983:
URL: https://github.com/apache/qpid-dispatch/pull/983


   I found one visual regression in this: the console page does not fill the entire browser viewport; this is most visible when the side panel is collapsed and white bars of empty space show on the left and the bottom of the page. In the second screenshot, notice two scrollbars on the right of the page.
   
   Other than the issue above, I did not see anything else new. I will now try to upgrade Patternfly and maybe I will resolve the issue while doing that. If not, I will revisit it here.
   
   ![dashboard](https://user-images.githubusercontent.com/442720/104811432-a6190f00-57fb-11eb-873d-8ca83513e32d.png)
   
   ![entities](https://user-images.githubusercontent.com/442720/104811450-cea10900-57fb-11eb-8923-cecb2c948a21.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [qpid-dispatch] jiridanek commented on pull request #983: DISPATCH-1750 Update all console deps except Patternfly and d3

GitBox

jiridanek commented on pull request #983:
URL: https://github.com/apache/qpid-dispatch/pull/983#issuecomment-761988949


   I was able to fix the viewport issue by upgrading Patternfly in #984, so I guess we can ignore this PR and move onto that one.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [qpid-dispatch] jiridanek closed pull request #983: DISPATCH-1750 Update all console deps except Patternfly and d3

GitBox
In reply to this post by GitBox

jiridanek closed pull request #983:
URL: https://github.com/apache/qpid-dispatch/pull/983


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]