Review Request 61596: allow hostname to be set for sasl-init

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Review Request 61596: allow hostname to be set for sasl-init

Gordon Sim

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61596/
-----------------------------------------------------------

Review request for qpid and Andrew Stitcher.


Bugs: PROTON-1535
    https://issues.apache.org/jira/browse/PROTON-1535


Repository: qpid-proton-git


Description
-------

allow hostname to be set for sasl-init


Diffs
-----

  proton-c/include/proton/sasl-plugin.h cbc6684
  proton-c/src/sasl/sasl-internal.h fc141b4
  proton-c/src/sasl/sasl.c a39e602


Diff: https://reviews.apache.org/r/61596/diff/1/


Testing
-------


Thanks,

Gordon Sim

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Review Request 61596: allow hostname to be set for sasl-init

astitcher

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61596/#review182725
-----------------------------------------------------------



This looks fine.

Can you just confirm that adding this extra field to the frame is still amqp 1.0 protocol compliant (I dont have time to check that today).

- Andrew Stitcher


On Aug. 11, 2017, 5:24 p.m., Gordon Sim wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61596/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 5:24 p.m.)
>
>
> Review request for qpid and Andrew Stitcher.
>
>
> Bugs: PROTON-1535
>     https://issues.apache.org/jira/browse/PROTON-1535
>
>
> Repository: qpid-proton-git
>
>
> Description
> -------
>
> allow hostname to be set for sasl-init
>
>
> Diffs
> -----
>
>   proton-c/include/proton/sasl-plugin.h cbc6684
>   proton-c/src/sasl/sasl-internal.h fc141b4
>   proton-c/src/sasl/sasl.c a39e602
>
>
> Diff: https://reviews.apache.org/r/61596/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gordon Sim
>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Review Request 61596: allow hostname to be set for sasl-init

Gordon Sim


> On Aug. 11, 2017, 5:46 p.m., Andrew Stitcher wrote:
> > This looks fine.
> >
> > Can you just confirm that adding this extra field to the frame is still amqp 1.0 protocol compliant (I dont have time to check that today).

From spec:

<type name="sasl-init" class="composite" source="list" provides="sasl-frame">
<descriptor name="amqp:sasl-init:list" code="0x00000000:0x00000041"/>
<field name="mechanism" type="symbol" mandatory="true"/>
<field name="initial-response" type="binary"/>
<field name="hostname" type="string"/>
</type>

"This field can be used by AMQP proxies to determine the correct back-end service to connect the
client to, and to determine the domain to validate the client’s credentials against."


- Gordon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61596/#review182725
-----------------------------------------------------------


On Aug. 11, 2017, 5:24 p.m., Gordon Sim wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61596/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 5:24 p.m.)
>
>
> Review request for qpid and Andrew Stitcher.
>
>
> Bugs: PROTON-1535
>     https://issues.apache.org/jira/browse/PROTON-1535
>
>
> Repository: qpid-proton-git
>
>
> Description
> -------
>
> allow hostname to be set for sasl-init
>
>
> Diffs
> -----
>
>   proton-c/include/proton/sasl-plugin.h cbc6684
>   proton-c/src/sasl/sasl-internal.h fc141b4
>   proton-c/src/sasl/sasl.c a39e602
>
>
> Diff: https://reviews.apache.org/r/61596/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gordon Sim
>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Review Request 61596: allow hostname to be set for sasl-init

astitcher
In reply to this post by Gordon Sim

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61596/#review182734
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Stitcher


On Aug. 11, 2017, 5:24 p.m., Gordon Sim wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61596/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 5:24 p.m.)
>
>
> Review request for qpid and Andrew Stitcher.
>
>
> Bugs: PROTON-1535
>     https://issues.apache.org/jira/browse/PROTON-1535
>
>
> Repository: qpid-proton-git
>
>
> Description
> -------
>
> allow hostname to be set for sasl-init
>
>
> Diffs
> -----
>
>   proton-c/include/proton/sasl-plugin.h cbc6684
>   proton-c/src/sasl/sasl-internal.h fc141b4
>   proton-c/src/sasl/sasl.c a39e602
>
>
> Diff: https://reviews.apache.org/r/61596/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gordon Sim
>
>

Loading...