[jira] [Commented] (DISPATCH-1974) Fix and remove ignores in flake8 configuration

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (DISPATCH-1974) Fix and remove ignores in flake8 configuration

ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/DISPATCH-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17292123#comment-17292123 ]

ASF GitHub Bot commented on DISPATCH-1974:
------------------------------------------

codecov-io commented on pull request #1058:
URL: https://github.com/apache/qpid-dispatch/pull/1058#issuecomment-787066203


   # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1058?src=pr&el=h1) Report
   > Merging [#1058](https://codecov.io/gh/apache/qpid-dispatch/pull/1058?src=pr&el=desc) (00c3183) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/a0451227c7480e89b0892ffa962e77d157ffc370?el=desc) (a045122) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/1058/graphs/tree.svg?width=650&height=150&src=pr&token=rk2Cgd27pP)](https://codecov.io/gh/apache/qpid-dispatch/pull/1058?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1058      +/-   ##
   ==========================================
   - Coverage   82.33%   82.33%   -0.01%    
   ==========================================
     Files         111      111              
     Lines       27472    27472              
   ==========================================
   - Hits        22620    22619       -1    
   - Misses       4852     4853       +1    
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1058?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1058/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `92.64% <0.00%> (-0.40%)` | :arrow_down: |
   | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1058/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `92.45% <0.00%> (-0.22%)` | :arrow_down: |
   | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1058/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `87.07% <0.00%> (-0.08%)` | :arrow_down: |
   | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1058/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `84.79% <0.00%> (ø)` | |
   | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1058/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j) | `86.78% <0.00%> (+0.10%)` | :arrow_up: |
   | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1058/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.12% <0.00%> (+0.38%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1058?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1058?src=pr&el=footer). Last update [a045122...00c3183](https://codecov.io/gh/apache/qpid-dispatch/pull/1058?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


> Fix and remove ignores in flake8 configuration
> ----------------------------------------------
>
>                 Key: DISPATCH-1974
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1974
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>    Affects Versions: 1.16.0
>            Reporter: Jiri Daněk
>            Priority: Major
>
> Fixes with autopep8 in DISPATCH-1814 resolved many flake8 warnings. There are still warnings left that require human consideration and fixing.
> For example, usage of bare {{except}} in the code.
> This must be fixed manually. Fixed issues should then be removed from the tox.ini flake8 ignore section.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]