[jira] [Commented] (DISPATCH-1980) python checker test should check only files committed to git and no others

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (DISPATCH-1980) python checker test should check only files committed to git and no others

ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/DISPATCH-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293913#comment-17293913 ]

Jiri Daněk commented on DISPATCH-1980:
--------------------------------------

[~chug] When dealing with Java/Maven, you don't explicitly specify which files to compile (in something like CMakeLists.txt), instead, all *.java files under src/ are compiled by default, and if any of them fails to compile, the build fails, regardless of the file's git status. So the current behavior is not unprecedented.

Listing the flies to check with flake8 explicitly in tox.ini is a no-go, in my opinion, it would be just one more list that is tedious and error prone to maintain. I am not a fan of the idea of consulting {{git ls-tree}} to filter out untracked files, but in principle I'd be ok with that.

Can't logger.py be merged into the repo, if the tool is useful?

> python checker test should check only files committed to git and no others
> --------------------------------------------------------------------------
>
>                 Key: DISPATCH-1980
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1980
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Tests, Tools
>    Affects Versions: 1.15.0
>            Reporter: Charles E. Rolke
>            Assignee: Charles E. Rolke
>            Priority: Major
>             Fix For: 1.16.0
>
>
> {code:java}
> 73: py39 run-test: commands[0] | flake8 --count --show-source /home/chug/git/qpid-dispatch/python /home/chug/git/qpid-dispatch/console /home/chug/git/qpid-dispatch/docs /home/chug/git/qpid-dispatch/tests /home/chug/git/qpid-dispatch/tools /home/chug/git/qpid-dispatch/tools/qdstat /home/chug/git/qpid-dispatch/tools/qdmanage
> 73: /home/chug/git/qpid-dispatch/tools/scraper/logger.py:6:13: E401 multiple imports on one line
> 73: import errno, os, time, socket, random, subprocess, shutil, unittest, __main__, re, sys
> 73:             ^
> 73: /home/chug/git/qpid-dispatch/tools/scraper/logger.py:9:1: E302 expected 2 blank lines, found 1
> 73: class Timestamp(object):
> 73: ^
> 73: /home/chug/git/qpid-dispatch/tools/scraper/logger.py:33:26: E201 whitespace after '('
> 73:         self.logs.append( (ts, msg) )
> 73:                          ^
> 73: /home/chug/git/qpid-dispatch/tools/scraper/logger.py:33:36: E202 whitespace before ')'
> 73:         self.logs.append( (ts, msg) )
> 73:                                    ^
> 73: /home/chug/git/qpid-dispatch/tools/scraper/logger.py:49:1: E305 expected 2 blank lines after class or function definition, found 1
> 73: log = Logger()
> 73: ^
> 73: 5
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]