[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (PROTON-2322) Fix and remove ignores in flake8 configuration

ASF subversion and git services (Jira)

    [ https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266128#comment-17266128 ]

ASF GitHub Bot commented on PROTON-2322:
----------------------------------------

astitcher commented on a change in pull request #289:
URL: https://github.com/apache/qpid-proton/pull/289#discussion_r558389831



##########
File path: python/proton/_delivery.py
##########
@@ -34,7 +34,7 @@
 
 
 class NamedInt(int):
-    values = {}  # type: Dict[int, str]

Review comment:
       Also re type comments - I'm much more interested in typeshed (as in separate) function level type annotations - I think I put that comment there as a helpful piece of user level info to help me understand the code.
   I don't think having flake8 check this is very useful tbh, so just stop it checking type annotation for the moment.
   If I want type checking I'm going to use mypy




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


> Fix and remove ignores in flake8 configuration
> ----------------------------------------------
>
>                 Key: PROTON-2322
>                 URL: https://issues.apache.org/jira/browse/PROTON-2322
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: python-binding
>    Affects Versions: proton-c-0.34.0
>            Reporter: Jiri DanÄ›k
>            Priority: Major
>
> Fixes with autopep8 in PROTON-2320 resolved most of flake8 warnings. There are still warnings left that require human consideration and fixing.
> For example, usage of bare {{except}} in the code.
> This must be fixed manually. Fixed issues should then be removed from the tox.ini flake8 ignore section.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]