[jira] [Created] (QPID-3977) Add charting framework for new distributed tests framwork

Keith Wall created QPID-3977:
--------------------------------

             Summary: Add charting framework for new distributed tests framwork
                 Key: QPID-3977
                 URL: https://issues.apache.org/jira/browse/QPID-3977
             Project: Qpid
          Issue Type: New Feature
          Components: Java Tests
            Reporter: Keith Wall
            Assignee: Philip Harvey
             Fix For: 0.17


We would like a framework that makes it easy to run configuration-driven distributed Qpid tests.

The framework should read a configuration file that specifies a number of queues, producers, and consumers. It should then run the test, collecting statistics along the way.

This is being initially implemented in Java, but is ultimately intended to be language-neutral.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

     [ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Wall updated QPID-3977:
-----------------------------

    Description:
We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.


  was:
We would like a framework that makes it easy to run configuration-driven distributed Qpid tests.

The framework should read a configuration file that specifies a number of queues, producers, and consumers. It should then run the test, collecting statistics along the way.

This is being initially implemented in Java, but is ultimately intended to be language-neutral.

       Assignee: Keith Wall  (was: Philip Harvey)
   

> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
>                 Key: QPID-3977
>                 URL: https://issues.apache.org/jira/browse/QPID-3977
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: 0.17
>
>
> We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

     [ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Wall updated QPID-3977:
-----------------------------

    Description:
We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.

As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard build or distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.




  was:
We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.


   

> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
>                 Key: QPID-3977
>                 URL: https://issues.apache.org/jira/browse/QPID-3977
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: 0.17
>
>
> We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard build or distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

     [ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Wall updated QPID-3977:
-----------------------------

    Description:
We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.

As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard Java build nor does it form part of the distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.

The following build command will download the optional components and perform the build:

{code}
ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true -Dmodules.opt=perftests/visualisation-jfc
{code}




  was:
We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.

As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard build or distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.




   

> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
>                 Key: QPID-3977
>                 URL: https://issues.apache.org/jira/browse/QPID-3977
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: 0.17
>
>
> We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard Java build nor does it form part of the distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

     [ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Wall reassigned QPID-3977:
--------------------------------

    Assignee: Philip Harvey  (was: Keith Wall)
   

> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
>                 Key: QPID-3977
>                 URL: https://issues.apache.org/jira/browse/QPID-3977
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Philip Harvey
>             Fix For: 0.17
>
>
> We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard Java build nor does it form part of the distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

     [ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Wall reassigned QPID-3977:
--------------------------------

    Assignee: Keith Wall  (was: Philip Harvey)
   

> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
>                 Key: QPID-3977
>                 URL: https://issues.apache.org/jira/browse/QPID-3977
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: 0.17
>
>
> We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard Java build nor does it form part of the distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

     [ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Wall updated QPID-3977:
-----------------------------

    Status: Ready To Review  (was: In Progress)
   

> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
>                 Key: QPID-3977
>                 URL: https://issues.apache.org/jira/browse/QPID-3977
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: 0.17
>
>
> We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard Java build nor does it form part of the distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

     [ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Wall reassigned QPID-3977:
--------------------------------

    Assignee: Philip Harvey  (was: Keith Wall)
   

> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
>                 Key: QPID-3977
>                 URL: https://issues.apache.org/jira/browse/QPID-3977
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Philip Harvey
>             Fix For: 0.17
>
>
> We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard Java build nor does it form part of the distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

    [ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290108#comment-13290108 ]

Philip Harvey commented on QPID-3977:
-------------------------------------

Code reviewed and all looks fine.

* I didn't find running ChartUtil very intuitive. It seems that the command line needs to be something like:

java -cp ".:${QPID_HOME}/lib/*" -DcsvCurrentDir=/location/of/csv/files org.apache.qpid.disttest.charting.ChartingUtil chart-defs=/location/of/chartdefs/

Is there a reason why the csv directory is specified with a system property rather than a command line argument?

* I do think it would be worth modifying ChartUtils to print usage if it's run with no/invalid args.

* On a related point, I don't think command line option "outputdir" is used anywhere.

               

> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
>                 Key: QPID-3977
>                 URL: https://issues.apache.org/jira/browse/QPID-3977
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Philip Harvey
>             Fix For: 0.17
>
>
> We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard Java build nor does it form part of the distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

     [ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philip Harvey reassigned QPID-3977:
-----------------------------------

    Assignee: Keith Wall  (was: Philip Harvey)

I've added code review comments for you to consider.
               

> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
>                 Key: QPID-3977
>                 URL: https://issues.apache.org/jira/browse/QPID-3977
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: 0.17
>
>
> We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard Java build nor does it form part of the distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

    [ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290463#comment-13290463 ]

Keith Wall edited comment on QPID-3977 at 6/6/12 9:54 PM:
----------------------------------------------------------

Add support for 3D bar/line charts; XY line charts, chart subtitles, and add Main-Class/Class-Path manifest entries to visualisation JAR to allow for easy use from command line.

Patch uploaded for safe keeping.
               
      was (Author: k-wall):
    Add support for 3D bar/line charts; XY line charts, chart subtitles, and add Main-Class/Class-Path manifest entries to visualisation JAR to allow for easy use from command line.

Patch uploaded fot safe keeping.
                 

> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
>                 Key: QPID-3977
>                 URL: https://issues.apache.org/jira/browse/QPID-3977
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: 0.17
>
>         Attachments: 0001-QPID-3977-Add-support-for-3D-bar-line-charts-XY-line.patch
>
>
> We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard Java build nor does it form part of the distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

     [ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Wall updated QPID-3977:
-----------------------------

    Attachment: 0001-QPID-3977-Add-support-for-3D-bar-line-charts-XY-line.patch

Add support for 3D bar/line charts; XY line charts, chart subtitles, and add Main-Class/Class-Path manifest entries to visualisation JAR to allow for easy use from command line.

Patch uploaded fot safe keeping.
               

> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
>                 Key: QPID-3977
>                 URL: https://issues.apache.org/jira/browse/QPID-3977
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: 0.17
>
>         Attachments: 0001-QPID-3977-Add-support-for-3D-bar-line-charts-XY-line.patch
>
>
> We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard Java build nor does it form part of the distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

     [ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philip Harvey updated QPID-3977:
--------------------------------

    Attachment: 0001-QPID-3977-ChartingUtil-now-generates-chart-summary.h.patch

ChartingUtil now generates chart-summary.html file to facilitate chart png browsing from CI server.

This patch is intended to be applied on top of the one that Keith already attached to this JIRA.
               

> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
>                 Key: QPID-3977
>                 URL: https://issues.apache.org/jira/browse/QPID-3977
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: 0.17
>
>         Attachments: 0001-QPID-3977-Add-support-for-3D-bar-line-charts-XY-line.patch, 0001-QPID-3977-ChartingUtil-now-generates-chart-summary.h.patch
>
>
> We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard Java build nor does it form part of the distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

     [ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Wall updated QPID-3977:
-----------------------------

    Attachment:     (was: 0001-QPID-3977-Add-support-for-3D-bar-line-charts-XY-line.patch)
   

> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
>                 Key: QPID-3977
>                 URL: https://issues.apache.org/jira/browse/QPID-3977
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: 0.17
>
>         Attachments: 0001-QPID-3977-ChartingUtil-now-generates-chart-summary.h.patch
>
>
> We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard Java build nor does it form part of the distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

    [ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295670#comment-13295670 ]

Keith Wall commented on QPID-3977:
----------------------------------

Hi Phil, I reviewed you patch and had no comments.
               

> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
>                 Key: QPID-3977
>                 URL: https://issues.apache.org/jira/browse/QPID-3977
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: 0.17
>
>         Attachments: 0001-QPID-3977-ChartingUtil-now-generates-chart-summary.h.patch
>
>
> We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard Java build nor does it form part of the distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

    [ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295671#comment-13295671 ]

Keith Wall commented on QPID-3977:
----------------------------------

Patches applied.
               

> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
>                 Key: QPID-3977
>                 URL: https://issues.apache.org/jira/browse/QPID-3977
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: 0.17
>
>         Attachments: 0001-QPID-3977-ChartingUtil-now-generates-chart-summary.h.patch
>
>
> We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard Java build nor does it form part of the distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

     [ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Wall updated QPID-3977:
-----------------------------

    Status: Open  (was: Ready To Review)

Phil's original review comments still stand.  Setting to rejected until this work is done.
               

> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
>                 Key: QPID-3977
>                 URL: https://issues.apache.org/jira/browse/QPID-3977
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: 0.17
>
>         Attachments: 0001-QPID-3977-ChartingUtil-now-generates-chart-summary.h.patch
>
>
> We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard Java build nor does it form part of the distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

     [ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philip Harvey updated QPID-3977:
--------------------------------

    Attachment: 0002-QPID-3977-tidy-up-chart-generation.-Specifically.patch

attached patch to tidy up some aspects of chart generation
               

> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
>                 Key: QPID-3977
>                 URL: https://issues.apache.org/jira/browse/QPID-3977
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: 0.17
>
>         Attachments: 0001-QPID-3977-ChartingUtil-now-generates-chart-summary.h.patch, 0002-QPID-3977-tidy-up-chart-generation.-Specifically.patch
>
>
> We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard Java build nor does it form part of the distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

     [ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philip Harvey updated QPID-3977:
--------------------------------

    Attachment: 0001-QPID-3977-fixed-in-previous-patch-where-we-tried-to-.patch

attached patch to fix problems in previous one
               

> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
>                 Key: QPID-3977
>                 URL: https://issues.apache.org/jira/browse/QPID-3977
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: 0.17
>
>         Attachments: 0001-QPID-3977-ChartingUtil-now-generates-chart-summary.h.patch, 0001-QPID-3977-fixed-in-previous-patch-where-we-tried-to-.patch, 0002-QPID-3977-tidy-up-chart-generation.-Specifically.patch
>
>
> We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard Java build nor does it form part of the distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

    [ https://issues.apache.org/jira/browse/QPID-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407214#comment-13407214 ]

Keith Wall commented on QPID-3977:
----------------------------------

Patches applied.
               

> Add charting framework for new distributed tests framwork
> ---------------------------------------------------------
>
>                 Key: QPID-3977
>                 URL: https://issues.apache.org/jira/browse/QPID-3977
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: 0.17
>
>         Attachments: 0001-QPID-3977-ChartingUtil-now-generates-chart-summary.h.patch, 0001-QPID-3977-fixed-in-previous-patch-where-we-tried-to-.patch, 0002-QPID-3977-tidy-up-chart-generation.-Specifically.patch
>
>
> We need a flexible charting mechanism to allow the performance figures produced by the new distributed test tool (QPID-3936) to be readily understood.   This new Java module uses JFreeChart to produce charts from the CSV files produced by the tool.
> As the licences of the dependencies of this module are not Apache 2.0 compatible, the new module perftests/visualisation-jfc is optional and is not part of the standard Java build nor does it form part of the distributables.  If the user wishes to use this module, they must download the JARs themselves.  This is the same approach as used by the bdbstore.
> The following build command will download the optional components and perform the build:
> {code}
> ant build test -Ddownload-csvjdbc=true -Ddownload-jfree=true -Dmodules.opt=perftests/visualisation-jfc
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]