[jira] [Resolved] (QPID-7664) [Java Broker] [AMQP1.0] Support defaultOutcome handling

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Resolved] (QPID-7664) [Java Broker] [AMQP1.0] Support defaultOutcome handling

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/QPID-7664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Rudyy resolved QPID-7664.
    Resolution: Fixed

Lorenz and I worked on the changes for this JIRA together. The changes have been reviewed whilst working in pair

> [Java Broker] [AMQP1.0] Support defaultOutcome handling
> -------------------------------------------------------
>                 Key: QPID-7664
>                 URL: https://issues.apache.org/jira/browse/QPID-7664
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Keith Wall
>             Fix For: qpid-java-broker-7.0.0
> -The Java Broker currently does not respect the source's {{defaultOutcome}}, despite concurring with the peer's choice.-
> -[http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#type-source]-
> -It currently arbitrarily decides to use a Modified\{deliveryFailed=true\} in some cases rather than respecting the default.  Code is ({{org.apache.qpid.server.protocol.v1_0.ConsumerTarget_1_0.DispositionAction}}).-
> Since the JIRA was raised the code was changed and we no longer set the defaultOutcome on the Source for -sending- receiving links (QPID-7658).
> On receiving links we immediately apply a terminal outcome (except for transacted transfers were we use TransactionalState containing the terminal outcome).
> So if my reading of the spec is correct the default outcome would only apply when receiving presettled messages.
> However, this does not make a lot of sense, IMHO. For example if the sender requests a default outcome of Accepted and sends a presettled message that we do not want or can't accept we would have to apply the Accepted outcome anyway? On the other hand if the sender requests a default outcome of Rejected and sends a presettled message should we immediately drop it? Then why send it in the first place?

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]