[qpid-dispatch] branch master updated: DISPATCH-1906: fix coverity false positive [pass_freed_arg]

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[qpid-dispatch] branch master updated: DISPATCH-1906: fix coverity false positive [pass_freed_arg]

kgiusti
This is an automated email from the ASF dual-hosted git repository.

kgiusti pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/qpid-dispatch.git


The following commit(s) were added to refs/heads/master by this push:
     new 41139d8  DISPATCH-1906: fix coverity false positive [pass_freed_arg]
41139d8 is described below

commit 41139d8c5a68631060029d5e89675aaa42092133
Author: Kenneth Giusti <[hidden email]>
AuthorDate: Wed Jan 6 11:42:17 2021 -0500

    DISPATCH-1906: fix coverity false positive [pass_freed_arg]
---
 src/adaptors/http1/http1_server.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/adaptors/http1/http1_server.c b/src/adaptors/http1/http1_server.c
index f020f70..45d31f2 100644
--- a/src/adaptors/http1/http1_server.c
+++ b/src/adaptors/http1/http1_server.c
@@ -436,6 +436,8 @@ static void _do_reconnect(void *context)
     // qdr_http1_server_core_link_deliver callback until the request message is
     // complete.
 
+    // false positive: head request is removed before it is freed, null is passed
+    /* coverity[pass_freed_arg] */
     if (!_is_request_in_progress((_server_request_t*) DEQ_HEAD(hconn->requests))) {
         qd_log(qdr_http1_adaptor->log, QD_LOG_DEBUG,
                "[C%"PRIu64"] Connecting to HTTP server...", conn_id);


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]